Adding region-specifc domain suffix for sts endpoints and adding new regions and domain suffixes#234
Merged
seanzatzdev-amazon merged 7 commits intoaws:masterfrom Oct 1, 2024
Merged
Conversation
seanzatzdev-amazon
approved these changes
Sep 13, 2024
Contributor
seanzatzdev-amazon
left a comment
seanzatzdev-amazon
left a comment
There was a problem hiding this comment.
Let's add some unit tests for the new functions that are added
Contributor
Author
|
@seanzatzdev-amazon I added unit tests and everything is passing. Please let me know if you want more or different tests |
Contributor
Author
|
@seanzatzdev-amazon is there any more needed before we can merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Addresses STS_ENDPOINT_URL hardcoded dns name suffix
Description of changes:
Added a helper function to pull region-specific domain name suffix strings from the
efs-utils.conffile in order to allow authentication via webidentity to hit the proper STS endpoint for those regions. Modifiedmount_efsandwatchdogscripts as well as added some missing regions and their domain suffixes to theefs-utils.conffile.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.