Fix EFS_FQDN_RE to support ADC DNS suffixes with hyphens#325
Merged
samuhale merged 1 commit intoaws:masterfrom Feb 23, 2026
Merged
Fix EFS_FQDN_RE to support ADC DNS suffixes with hyphens#325samuhale merged 1 commit intoaws:masterfrom
samuhale merged 1 commit intoaws:masterfrom
Conversation
The dns_name_suffix capture group in EFS_FQDN_RE used [a-z0-9.] which does not match hyphens. ADC regions like NCL use DNS suffix 'cloud.adc-e.uk' which contains a hyphen, causing mount.efs to reject the FQDN with 'did not resolve to a valid DNS name for an EFS mount target'. Add hyphen to the character class: [a-z0-9.-]
samuhale
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dns_name_suffix capture group in EFS_FQDN_RE used [a-z0-9.] which does not match hyphens. ADC regions like NCL use DNS suffix 'cloud.adc-e.uk' which contains a hyphen, causing mount.efs to reject the FQDN with 'did not resolve to a valid DNS name for an EFS mount target'.
Add hyphen to the character class: [a-z0-9.-], and associated test