-
Notifications
You must be signed in to change notification settings - Fork 84
Migrate styling UI panels to styled type atoms #1727
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestperformanceIssues relating to performanceIssues relating to performanceschemaIssues related to the schema definition or synchronizationIssues related to the schema definition or synchronizationtech debtIssues, typically tasks, that are mainly about cleaning up code that is problematic in some wayIssues, typically tasks, that are mainly about cleaning up code that is problematic in some way
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestperformanceIssues relating to performanceIssues relating to performanceschemaIssues related to the schema definition or synchronizationIssues related to the schema definition or synchronizationtech debtIssues, typically tasks, that are mainly about cleaning up code that is problematic in some wayIssues, typically tasks, that are mainly about cleaning up code that is problematic in some way
Description
The NodesStyling and EdgesStyling panels currently read from
mergedConfigurationSelectoranddisplayVertexTypeConfigSelectorto get combined schema + style data. These should be migrated to the newstyledVertexTypeAtom(type)/styledEdgeTypeAtom(type)atoms introduced in #1725.Style changes already write to the same preference atoms, so only the read side needs to change.
Preferred Solution
{ schema, preferences }from the new styled atomsdisplayVertexTypeConfigSelector/displayEdgeTypeConfigSelectorin these panels{ schema, preferences }shape keeps schema and style data separate, improving referential stabilityRelated Issues
Important
If you are interested in working on this issue, please leave a comment.
Tip
Please use a 👍 reaction to provide a +1/vote. This helps the community and maintainers prioritize this request.