Skip to content

Add ability to wrap component with spinner#1025

Merged
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:spinner
Jun 18, 2025
Merged

Add ability to wrap component with spinner#1025
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:spinner

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Jun 18, 2025

Description

I saw this pattern and knew it would be easy to implement and could be useful.

The spinner component can now wrap another component. When the loading flag is true the spinner is shown instead of the wrapped component. No layout shift will occur.

My inspiration came from Radix UI.

Validation

  • Changed the sync icon in the connection details to use this style to verify it works propeerly
  • Tested other uses of spinner to make sure they still work correctly

Related Issues

  • None

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review June 18, 2025 15:07
@kmcginnes kmcginnes requested a review from andreachild June 18, 2025 15:07
andreachild
andreachild previously approved these changes Jun 18, 2025
@kmcginnes kmcginnes merged commit 90368d7 into aws:main Jun 18, 2025
2 checks passed
@kmcginnes kmcginnes deleted the spinner branch June 18, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants