Skip to content

Comments

Reorganize result types in to connector namespace#1114

Merged
kmcginnes merged 6 commits intoaws:mainfrom
kmcginnes:search/reorganize-result-type
Aug 23, 2025
Merged

Reorganize result types in to connector namespace#1114
kmcginnes merged 6 commits intoaws:mainfrom
kmcginnes:search/reorganize-result-type

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Aug 19, 2025

Description

  • Move fetchEntityDetails() to @/connector module
  • Move result entities to @/connector/entities module

Validation

  • Smoke tested

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review August 19, 2025 22:40
Copy link
Contributor

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring. I think this will clean things up in the longer term

@kmcginnes kmcginnes merged commit 5bf84be into aws:main Aug 23, 2025
2 checks passed
@kmcginnes kmcginnes deleted the search/reorganize-result-type branch August 23, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorganize query related code out of core

2 participants