Skip to content

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Oct 29, 2025

Description

When accessing the style dialog from the graph context menu, Graph Explorer would switch to the node/edge style sidebar then show the dialog. This doesn't make much sense to do.

Now the dialog is hosted by the GraphExplorer, which is the root of the route. So, the dialog can be shown without switching to the correct side bar first.

I also changed it so that the node/edge no longer is selected.

Validation

  • Tested customize node/edge from context menu
  • Tested customize node/edge from sidebar panels
  • Tested with auto open details toggled on

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review October 29, 2025 22:43
@kmcginnes kmcginnes merged commit 18d1b47 into aws:main Oct 29, 2025
2 checks passed
@kmcginnes kmcginnes deleted the fix/style-dialogs branch October 29, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants