Set explicit minimum permissions on GitHub Actions workflows#1573
Merged
Set explicit minimum permissions on GitHub Actions workflows#1573
Conversation
Move permissions to the workflow level with contents: read for all three workflows. This follows the principle of least privilege and ensures any future jobs inherit the restricted token by default. - unit.yml: Add permissions (was missing entirely) - build_docker.yml: Move from job level to workflow level - test_build_docker.yml: Move from job level to workflow level
acarbonetto
approved these changes
Mar 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
===========================================
+ Coverage 47.81% 64.92% +17.11%
===========================================
Files 382 372 -10
Lines 8525 8382 -143
Branches 3159 3123 -36
===========================================
+ Hits 4076 5442 +1366
+ Misses 3070 2085 -985
+ Partials 1379 855 -524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set explicit minimum permissions (
contents: read) at the workflow level on all three GitHub Actions workflows. This follows the principle of least privilege and ensures any future jobs inherit restricted token permissions by default.permissions: contents: readtounit.yml(was missing entirely)permissionsfrom job level to workflow level inbuild_docker.ymlpermissionsfrom job level to workflow level intest_build_docker.ymlValidation
permissions: contents: readat the top levelpermissionsblocks remainRelated Issues
N/A
Check List
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.