Improve error details with richer diagnostic information#1644
Merged
Improve error details with richer diagnostic information#1644
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1644 +/- ##
===========================================
+ Coverage 47.81% 63.04% +15.23%
===========================================
Files 382 396 +14
Lines 8525 9235 +710
Branches 3159 3514 +355
===========================================
+ Hits 4076 5822 +1746
+ Misses 3070 2368 -702
+ Partials 1379 1045 -334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acarbonetto
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Error Details dialog previously showed only the error name and message, which often duplicated the user-friendly display error without adding diagnostic value. This change makes the details dialog genuinely useful for troubleshooting by surfacing status codes, response data, cause chains, and structured validation errors.
createErrorDetailsfromErrorDetailsButtoninto a standalone tested functionNetworkError(e.g., "500 Internal Server Error")statusTextproperty toNetworkErrorbacked by anHTTP_STATUS_TEXTlookuperror.causechains with all own properties (excluding stack traces)ZodErrorissues as structured JSON in the data fieldextractErrorMessageto generically pull messages from error response bodies usingdetailedMessage,message,description, orerrorfieldsNeptuneErrorSchemain favor of the genericextractErrorMessageapproachtext-muted-foregroundtoLabelfor better visual distinction in the dialogValidation
pnpm run checkspasses (lint, format, types)pnpm testpasses (1483/1483 tests across 141 files)createErrorDetailscovering NetworkError, ZodError, DOMException, Error with cause chains, and non-Error valuesextractErrorMessagecovering all key priorities and edge casesRelated Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.