Preserve URL path when proxy constructs database endpoint URLs#1761
Merged
Preserve URL path when proxy constructs database endpoint URLs#1761
Conversation
The proxy server used absolute paths in new URL() calls which replaced the entire base URL path. This broke databases with non-root endpoints like BlazeGraph (/blazegraph/namespace/kb/sparql). Extract resolveEndpointUrl helper that ensures a trailing slash on the base URL before resolving relative endpoint paths. Add tests for path preservation across proxy, client-side URL construction, connection normalization, and environment variable parsing. Fixes aws#1752
arseny-kostenko
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The proxy server used absolute paths in
new URL()calls (e.g.,new URL("/sparql", baseUrl)) which replaced the entire base URL path. This broke databases with non-root endpoints like BlazeGraph (/blazegraph/namespace/kb/sparql).resolveEndpointUrlhelper that ensures a trailing slash on the base URL before resolving relative endpoint pathsValidation
/blazegraph/namespace/kb/sparqlreturns real SPARQL resultsresolveEndpointUrlrejects absolute paths ("/sparql"→ compile error)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.