Skip to content

Update label to be Neptune Analytics (not Graph)#811

Merged
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:neptune-analytics-label
Feb 28, 2025
Merged

Update label to be Neptune Analytics (not Graph)#811
kmcginnes merged 2 commits intoaws:mainfrom
kmcginnes:neptune-analytics-label

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Feb 28, 2025

Description

Update the service type drop down to be "Neptune Analytics" instead of "Neptune Graph".

I searched the codebase for any other occurrences, but I didn't find any.

Validation

CleanShot 2025-02-28 at 15 24 06@2x

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review February 28, 2025 21:27
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.94%. Comparing base (46372f5) to head (6bf1d8d).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
.../src/modules/CreateConnection/CreateConnection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   20.96%   27.94%   +6.98%     
==========================================
  Files         523      524       +1     
  Lines       22442    23673    +1231     
  Branches     1198     1238      +40     
==========================================
+ Hits         4704     6615    +1911     
+ Misses      17494    16927     -567     
+ Partials      244      131     -113     
Flag Coverage Δ
unittests 27.94% <0.00%> (+6.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreachild
Copy link
Contributor

LGTM!

@kmcginnes kmcginnes merged commit 533c672 into aws:main Feb 28, 2025
3 of 4 checks passed
@kmcginnes kmcginnes deleted the neptune-analytics-label branch February 28, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename service type "Neptune Graph" to "Neptune Analytics

2 participants