Skip to content

Fix deleting default connections#821

Merged
kmcginnes merged 4 commits intoaws:mainfrom
kmcginnes:fix-deleting-connection
Mar 5, 2025
Merged

Fix deleting default connections#821
kmcginnes merged 4 commits intoaws:mainfrom
kmcginnes:fix-deleting-connection

Conversation

@kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Mar 5, 2025

Description

There is an issue that seems to occur in a specific scenario:

  1. Open Graph Explorer for the first time
  2. Default connections created
  3. Delete default connection

It should delete the connection, but instead it immediately recreates the deleted connection. Further deletions work correctly.

To fix, I rearranged the logic in the AppStatusLoader effect.

  • Update default connection query to generate one connection per query engine, unless a specific query engine is specified
  • Check if any connections exist, if so skip default connection logic
  • Check if any default connections were received from the server, if not skip
  • Add all default connections to the connections storage
  • Set first connection as active
  • Reorder the query engine options to put the property graph options together and RDF last

Validation

  • Tested locally by creating a defaultConnection.json and deleting my local Graph Explorer database to simulate a first run

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review March 5, 2025 18:36
@kmcginnes kmcginnes force-pushed the fix-deleting-connection branch from 3b0d87f to bbdb244 Compare March 5, 2025 18:37
@andreachild
Copy link
Contributor

LGTM

@kmcginnes kmcginnes merged commit 60e56a5 into aws:main Mar 5, 2025
2 checks passed
@kmcginnes kmcginnes deleted the fix-deleting-connection branch March 5, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants