Add basic TextArea component #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
force-pushed
the
text-area-component
branch
2 times, most recently
from
a0fff61 to
64121d8
Compare
andreachild
reviewed
May 22, 2025
| } | ||
|
|
||
| /** @deprecated Use TextArea instead */ | ||
| const TextAreaField = forwardRef<HTMLTextAreaElement, TextAreaProps>( |
Contributor
There was a problem hiding this comment.
Nit: ValidatedTextArea is more descriptive than TextAreaField?
Collaborator
Author
There was a problem hiding this comment.
Hmm, I'm not sure I agree. The suffix "field" is what I've used for other legacy form components that include the interactive component, the label, and a validation message. But either the TextAreaField or the TextArea component can have validation. The TextArea component just doesn't supply the label and validation message.
I chose the term "field" because forms have the concept of a fieldset. In my head, at least, I consider a field to be the input, the label, and any description text or validation errors. But maybe that's a "me" thing.
andreachild
approved these changes
May 22, 2025
kmcginnes
force-pushed
the
text-area-component
branch
from
64121d8 to
27fbffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a basic
TextAreacomponent and renames the existing one toTextAreaFieldsince it has validation message and a container.Validation
Related Issues
Check List
license.
pnpm checksto ensure code compiles and meets standards.pnpm testto check if all tests are passing.Changelog.md.