fix(jsii-pacmak): comment lines should not contain comment ending#4193
Merged
mergify[bot] merged 7 commits intoaws:mainfrom Jul 26, 2023
Merged
Conversation
DanielMSchmidt
force-pushed
the
fix-java-documentation-escaping
branch
from
f582cc8 to
02de42f
Compare
packages/jsii-pacmak/test/generated-code/__snapshots__/target-java.test.js.snap
Outdated
Show resolved
Hide resolved
RomainMuller
approved these changes
Jul 26, 2023
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
|
Merging (with squash)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a comment contains
*/(for any reason, in our case because the escaped version is unescaped within JSII) it should be escaped to not make the file invalid