Skip to content

Conversation

@RomainMuller
Copy link
Contributor

Windows installation test has been failing with an odd error since the
shrinkwrap commit was introduced. Attempting to un-do this as a way to
confirm this is indeed what was causing problems.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Windows installation test has been failing with an odd error since the
shrinkwrap commit was introduced. Attempting to un-do this as a way to
confirm this is indeed what was causing problems.
@RomainMuller RomainMuller requested review from a team, assyadh, bmaizels and costleya as code owners August 12, 2019 22:42
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2019

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: 'BREAKING CHANGE: <describe what changed + link for details>'
    • Issues: Indicate issues fixed via: 'Fixes #xxx' or 'Closes #xxx'

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@RomainMuller RomainMuller merged commit a51876d into master Aug 12, 2019
@RomainMuller RomainMuller deleted the rmuller/unbreak-pipeline branch August 12, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants