create eni-max-pods.txt file in generated LT#1403
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 7c55bd0 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621568a62d0220000762943d |
d245d87 to
45c33d3
Compare
| %s | ||
| /etc/eks/bootstrap.sh '%s' %s \ | ||
| --apiserver-endpoint '%s'`, | ||
| p.ReplaceENIMaxPodsFile(ctx, constraints), |
There was a problem hiding this comment.
I worry that we're gonna run headlong into userdata limits with this approach.
There was a problem hiding this comment.
We could double the size of our user-data today and still be within limits.
We could also only populate the instance type options that we are going to launch. I'm doing all of them here for cache efficiency for the LT. Since we clean the LTs up now, it might be less of a big deal, other than the small bit of latency creating the LT.
|
@bwagner5 have you checked out the various issues with the current AL2 max pods implementation? My specific issue is awslabs/amazon-eks-ami#782 which might shed a bit more light on this? It also covers the reserved values which might also be something Karpenter should look at? I'm not sure what BottleRocket uses for these values but it's probably also worth considering? |
1. Issue, if available:
N/A
2. Description of changes:
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.