Skip to content

Conversation

@rli
Copy link
Contributor

@rli rli commented Sep 11, 2025

Problem

External IdP request behavior is not quite builderId and not quite like identityCenter

Solution

Add new type to runtimes and handle in language-serers

Related: aws/language-server-runtimes#679

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli rli requested a review from a team as a code owner September 11, 2025 22:04
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.87%. Comparing base (e0941d1) to head (af18d89).

Files with missing lines Patch % Lines
...codewhisperer/src/shared/streamingClientService.ts 61.53% 5 Missing ⚠️
...p-codewhisperer/src/shared/codeWhispererService.ts 25.00% 3 Missing ⚠️
...mazonQServiceManager/AmazonQTokenServiceManager.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2247      +/-   ##
==========================================
+ Coverage   59.71%   59.87%   +0.16%     
==========================================
  Files         254      254              
  Lines       56245    56262      +17     
  Branches     3337     3364      +27     
==========================================
+ Hits        33584    33688     +104     
+ Misses      22597    22509      -88     
- Partials       64       65       +1     
Flag Coverage Δ
unittests 59.87% <70.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rli rli merged commit 4d3b938 into aws:main Sep 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants