Skip to content

fix: strip vector search from indexing library + update indexing library to 75a7294a#2672

Merged
chungjac merged 1 commit intoaws:feature/removing-at-workspacefrom
chungjac:strip-vector-search-from-indexing
Apr 14, 2026
Merged

fix: strip vector search from indexing library + update indexing library to 75a7294a#2672
chungjac merged 1 commit intoaws:feature/removing-at-workspacefrom
chungjac:strip-vector-search-from-indexing

Conversation

@chungjac
Copy link
Copy Markdown
Contributor

@chungjac chungjac commented Mar 20, 2026

Problem

The @workspace vector/semantic search feature (ONNX + faiss + CodeSage model) is being removed.The qserver bundle zips still contain ~160MB of native binaries and ML models per platform that are no longer needed.

Solution

Updated the qserver-*.zip bundle assets with a rebuilt indexing library (75a7294a) that has all vector search code removed from AWSVectorConsolasLocalWorkspaceIndexing

  • Removed: ONNX runtime native binaries (dist/bin/), faiss native binaries (dist/build/), CodeSage model (models/)
  • Kept: extension.js (BM25 + context commands), tree-sitter.wasm, tree-sitter-wasms/ (21 language grammars), lspServer.js

Impact

  • Each qserver zip: ~100MB → 2.9MB (97% reduction)
  • All 5 platform zips are now identical (no platform-specific native binaries)
  • @file, @folder, @code continue to work
  • BM25 cross-file context for inline completions continues to work
  • @workspace / queryVectorIndex no longer functional (being removed)

Note

All 5 platform zips are now identical (no platform-specific native binaries). They could technically be combined into a single zip, but that would require changes across multiple build scripts (package.sh, lspArtifact.ts, build.gradle.kts, manifest generation, etc.), so keeping 5 individual zips for now.

Testing

  • E2E verified locally: @file, @folder, @code all work with stripped indexing bundle
  • No "Vector library failed" errors in logs

@chungjac chungjac requested a review from a team as a code owner March 20, 2026 22:52
@chungjac chungjac changed the title Strip vector search from indexing fix: strip vector search from indexing library Mar 20, 2026
@chungjac chungjac changed the title fix: strip vector search from indexing library fix: strip vector search from indexing library + update indexing library to db3ba00d Mar 20, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.44%. Comparing base (3a5079e) to head (dcc4f8c).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feature/removing-at-workspace    #2672      +/-   ##
=================================================================
+ Coverage                          60.43%   60.44%   +0.01%     
=================================================================
  Files                                278      278              
  Lines                              65867    65867              
  Branches                            4209     4211       +2     
=================================================================
+ Hits                               39806    39816      +10     
+ Misses                             25977    25967      -10     
  Partials                              84       84              
Flag Coverage Δ
unittests 60.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chungjac chungjac force-pushed the strip-vector-search-from-indexing branch from b0008eb to a0e0ce0 Compare March 20, 2026 23:09
@chungjac chungjac changed the base branch from main to feature/removing-at-workspace April 3, 2026 21:52
Remove ONNX, faiss, and CodeSage model from qserver bundles. The indexing
library no longer contains vector/semantic search code since @workspace is
being removed. Each qserver zip drops from ~100MB to ~2.9MB.

@file, @folder, @code continue to work (tree-sitter + BM25).
All 5 platform zips are now identical (no native binaries).
@chungjac chungjac force-pushed the strip-vector-search-from-indexing branch from a2a4f79 to dcc4f8c Compare April 6, 2026 23:11
@chungjac chungjac changed the title fix: strip vector search from indexing library + update indexing library to db3ba00d fix: strip vector search from indexing library + update indexing library to 75a7294a Apr 6, 2026
@chungjac chungjac merged commit d062948 into aws:feature/removing-at-workspace Apr 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants