fix: strip vector search from indexing library + update indexing library to 75a7294a#2672
Merged
chungjac merged 1 commit intoaws:feature/removing-at-workspacefrom Apr 14, 2026
Conversation
db3ba00d
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/removing-at-workspace #2672 +/- ##
=================================================================
+ Coverage 60.43% 60.44% +0.01%
=================================================================
Files 278 278
Lines 65867 65867
Branches 4209 4211 +2
=================================================================
+ Hits 39806 39816 +10
+ Misses 25977 25967 -10
Partials 84 84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b0008eb to
a0e0ce0
Compare
Remove ONNX, faiss, and CodeSage model from qserver bundles. The indexing library no longer contains vector/semantic search code since @workspace is being removed. Each qserver zip drops from ~100MB to ~2.9MB. @file, @folder, @code continue to work (tree-sitter + BM25). All 5 platform zips are now identical (no native binaries).
a2a4f79 to
dcc4f8c
Compare
db3ba00d75a7294a
Will-ShaoHua
approved these changes
Apr 7, 2026
aseemxs
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The @workspace vector/semantic search feature (ONNX + faiss + CodeSage model) is being removed.The qserver bundle zips still contain ~160MB of native binaries and ML models per platform that are no longer needed.
Solution
Updated the qserver-*.zip bundle assets with a rebuilt indexing library (
75a7294a) that has all vector search code removed from AWSVectorConsolasLocalWorkspaceIndexingImpact
Note
All 5 platform zips are now identical (no platform-specific native binaries). They could technically be combined into a single zip, but that would require changes across multiple build scripts (package.sh, lspArtifact.ts, build.gradle.kts, manifest generation, etc.), so keeping 5 individual zips for now.
Testing