Skip to content

Conversation

@konippi
Copy link
Contributor

@konippi konippi commented Nov 5, 2025

Summary

Changes

Please provide a summary of what's being changed

Add support for loading configuration from YAML files, allowing users to manage complex configurations more easily. CLI arguments take precedence over file configuration for maximum flexibility.

User experience

Please share what the user experience looks like before and after this change

Before

# Long command line with many arguments
mcp-proxy-for-aws https://example.com/mcp \
  --service my-service \
  --profile production \
  --region us-east-1 \
  --read-only \
  --log-level DEBUG \
  --retries 3 \
  --timeout 200

After

# Simple command with config file
mcp-proxy-for-aws --config config.yaml

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

  • Yes
  • No

Please add details about how this change was tested.

  • Did integration tests succeed?
  • If the feature is a new use case, is it necessary to add a new integration test case?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@konippi konippi requested a review from a team as a code owner November 5, 2025 13:47
@wzxxing
Copy link
Contributor

wzxxing commented Nov 5, 2025

Hi @konippi, thanks a lot for your PR.

Our project was only recently released so we did not have a mechanism for RFCs. This is a new feature and ideally we would like you to open a issue in the project. I will add this to the contributing guideline soon.

We do have plan to introduce a config feature, but it is not for local config, but the server-side config. And we are thinking of using --config parameter as a "append` argument (can be specified many times). e.g.

mcp-proxy-for-aws --config AWS_REGION=$AWS_REGION \
    --config readonly=true \
    --config timeout=30s
    <endpoint>

The config will be added to the JSON RPC message to send to the remote server. The feature is currently under development so we cannot merge this PR for now.

However, we do think having a config makes sense. We need to figure out a default location of this config such as in $XDG_CONFIG_HOME/mcp-proxy-for-aws.yaml or in ~/.aws/mcp-proxy-for-aws.yaml. It is also possible that the config can be in a aws profile because we have a --profile argument.

I will create a issue for this so that you can track the progress.

@konippi
Copy link
Contributor Author

konippi commented Nov 5, 2025

Thank you for explaining that to me. I'll close this PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants