Skip to content

Conversation

@sharmay
Copy link
Contributor

@sharmay sharmay commented Aug 6, 2024

Add notice to show create vs join status
Remove round() from restore %age

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Output in case of create_node (no delay were observed)

psql:../testing/db16-1-dsn.sql:5: NOTICE:  Checking status of pgactive.pgactive_create_group
psql:../testing/db16-1-dsn.sql:5: NOTICE:  successfully created first node pgactive.pgactive_create_group
 pgactive_wait_for_node_ready 
------------------------------
 
(1 row)

Output in case of join_node - success

psql:../testing/db16-2-dsn.sql:7: NOTICE:  Checking status of pgactive.pgactive_join_group
psql:../testing/db16-2-dsn.sql:7: NOTICE:  transferring of database 'pgadb' (1760 MB) from node pgactive1 in progress
psql:../testing/db16-2-dsn.sql:7: NOTICE:  transferring of database 'pgadb' (1760 MB) from node pgactive1 in progress
psql:../testing/db16-2-dsn.sql:7: NOTICE:  transferring of database 'pgadb' (1760 MB) from node pgactive1 in progress
psql:../testing/db16-2-dsn.sql:7: NOTICE:  transferring of database 'pgadb' (1760 MB) from node pgactive1 in progress
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  restoring database 'pgadb', 0% of 1760 MB complete
psql:../testing/db16-2-dsn.sql:7: NOTICE:  successfully joined the node and restored database 'pgadb' from node pgactive1
 pgactive_wait_for_node_ready 
------------------------------
 
(1 row)

Output in case of join_node - failure

NOTICE:  Checking status of pgactive.pgactive_join_group
NOTICE:  transferring of database 'pgadb' (1730 MB) from node pgactive1 in progress
<snip>
psql:../testing/db16-3-dsn.sql:6: ERROR:  could not detect a running pgactive perdb worker, current node state is i
DETAIL:  either pgactive perdb worker exited due to an error or it did not start in 300(s)
HINT:  Please check in PostgreSQL log file for more details.
CONTEXT:  PL/pgSQL function pgactive.pgactive_wait_for_node_ready(integer,integer) line 93 at RAISE

@sharmay sharmay self-assigned this Aug 6, 2024
@sharmay sharmay marked this pull request as ready for review August 13, 2024 14:42
Add checks for background workers
Added 5 min timeout for perdb worker
Remove unused variables
Update message as requested
Updated test.yml for docs folder name
Copy link
Contributor

@BRupireddy2 BRupireddy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharmay sharmay merged commit 2374d6f into aws:main Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants