Skip to content

Conversation

@austinjang2
Copy link

@austinjang2 austinjang2 commented Sep 18, 2025

  1. Updated sha on webview.diff
  2. Removed base-path patch
  3. Removed tar-fs-upgrade patch

Issue #, if available:

Description of changes:

  1. Webviews are normally served from vscode-webview.net but we want them self-hosted. When doing this, CSP will block resources like viewing images so we need to add 'self' to the CSP to fix the issue.
  2. base-path.diff was removed as it's superseded by base-path-compability.diff. The compability patch maps --base-path to --server-base-path, leveraging VSCode's existing base path handling instead of reimplementing it
  3. tar-fs-upgrade.patch was removed in 1.8 because the current VSCode submodule (2901c5ac6db) already includes a newer version of tar-fs, making this patch obsolete. Impact is low risk as this is just a dependency version bump.

Testing:
Run with command 'make run-local' which builds SageMaker Code Editor locally. Prior to this change, we discovered a bug through local testing in which CE was not able to open Python files/Jupyter notebooks, but issue was fixed after updating csp.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@austinjang2
Copy link
Author

austinjang2 commented Sep 18, 2025

Hash can be updated by:

  1. Running code-editor
  2. Opening dev-tool
  3. Check CSP error in console which will let you know what hash to use
  4. Update hash in respective html file.

Copy link

@aakashmandavilli96 aakashmandavilli96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aakashmandavilli96 aakashmandavilli96 merged commit e9c330b into aws:1.8 Sep 23, 2025
3 checks passed
@austinjang2 austinjang2 deleted the ajangg1.8 branch October 1, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants