fix(security): Handle multi-token command substitution in sendText sanitizer#236
Open
aakashmandavilli96 wants to merge 1 commit intoaws:1.7from
Open
Conversation
…nitizer
Add first-pass regex to match complete $(...), ${...}, and backtick
constructs followed by / before per-token processing. This prevents
bypass via multi-token payloads like $(curl google.com)/test.py where
the space inside $() caused the old per-token matcher to miss it.
Three-pass approach:
1. Escape complete substitution constructs followed by /
2. Escape patterns inside double-quoted paths with /
3. Escape residual patterns in unquoted path-like tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The terminal
sendTextsanitizer only escaped$()within single whitespace-delimited tokens. Multi-token payloads like$(curl google.com)/test.pyspan two tokens ($(curlandgoogle.com)/test.py), so the$(was never matched and the command substitution executed:Fix
Adds a first-pass regex that matches complete
$(...),${...}, and backtick constructs (including internal spaces) followed by/before per-token processing.Three-pass approach:
/(handles multi-token payloads)//Testing
sh ./scripts/install.sh$(curl google.com)/test.py→\$(curl google.com)/test.pyRelated: aws/code-editor#207