Skip to content
This repository was archived by the owner on Aug 26, 2020. It is now read-only.

Conversation

@mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Nov 20, 2018

Issue #, if available:
#137

Description of changes:
bug-fix: reintroduce _modules.prepare for backwards compatibility

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp mvsusp requested a review from laurenyu November 20, 2018 00:45
@laurenyu
Copy link
Contributor

also fix your PR title :)

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #138 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   95.39%   95.47%   +0.07%     
==========================================
  Files          20       20              
  Lines         825      839      +14     
  Branches       72       73       +1     
==========================================
+ Hits          787      801      +14     
  Misses         23       23              
  Partials       15       15
Impacted Files Coverage Δ
src/sagemaker_containers/_modules.py 97.05% <100%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e5150...d7f4ae0. Read the comment docs.

@mvsusp mvsusp merged commit b23264e into aws:master Nov 20, 2018
@mvsusp mvsusp deleted the mvs-prepare branch November 20, 2018 01:24
@mvsusp mvsusp changed the title Mvs prepare bug-fix: reintroduce _modules.prepare for backwards compatibility Nov 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants