This repository was archived by the owner on Aug 26, 2020. It is now read-only.
Add capture_error flag to process.check_error and process.create #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesterhazy
reviewed
Nov 20, 2018
src/sagemaker_containers/_errors.py
Outdated
|
|
||
| error_msg = decode_error() if self.output else '' | ||
|
|
||
| message = '%s:\nCommand "%s"\n%s' % (type(self).__name__, self.cmd, error_msg) |
Contributor
There was a problem hiding this comment.
this leaves extra newline in the message if error_msg is '' (self.output = None)
src/sagemaker_containers/_errors.py
Outdated
|
|
||
| def __str__(self): | ||
| message = '%s:\nCommand "%s"' % (type(self).__name__, self.cmd) | ||
| def decode_error(): |
Contributor
There was a problem hiding this comment.
why nested? why same name as member function?
mvsusp
changed the title
mvsusp
changed the title
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
+ Coverage 95.47% 95.53% +0.06%
==========================================
Files 20 20
Lines 840 852 +12
Branches 73 76 +3
==========================================
+ Hits 802 814 +12
Misses 23 23
Partials 15 15
Continue to review full report at Codecov.
|
jesterhazy
reviewed
Nov 20, 2018
CHANGELOG.rst
Outdated
| ===== | ||
|
|
||
| * feature: add capture_error flag to process.check_error and process.create and to | ||
| all functions that runs process: modules.run, modules,run_module, and entry_point.run |
Contributor
There was a problem hiding this comment.
should not be newline here
src/sagemaker_containers/_modules.py
Outdated
|
|
||
|
|
||
| def install(path): # type: (str) -> None | ||
| def install(path, capture_error=False): # type: (str) -> None |
jesterhazy
approved these changes
Nov 20, 2018
Contributor
jesterhazy
left a comment
jesterhazy
left a comment
There was a problem hiding this comment.
fix PR description, but otherwise LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
release: 2.3.4
all functions that runs process: modules.run, modules,run_module, and entry_point.run
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.