This repository was archived by the owner on Aug 26, 2020. It is now read-only.
Hardcode special case for tuning job hyperparameter #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChoiByungWook
approved these changes
May 14, 2018
laurenyu
added a commit
that referenced
this pull request
May 14, 2018
This change is a small improvement upon #54
mvsusp
added a commit
that referenced
this pull request
Jun 1, 2018
* add container support code (#1) * Add missing test dependencies to setup.py (#2) * Add entry.py as script in setup.py so it can be invoked from our images (#3) * Add data_files to setup.py to copy nginx config correctly + fix install_requires (#4) * Move dependencies from extras_require to install_requires * Copy in change from internal repo: support pip install requirements.txt (#5) * Use package_data instead of data_files to package config files, refer to (#6) * Add missing conf files (accidentally left out of previous commit) (#8) * pip install requirements in training container (#11) * Use container exit code to exit Trainer process. (#9) * Add gunicorn and gevent as setup.py dependencies (#13) * Specify version ranges for install_requires dependencies * Add Apache license headers (#14) * Add changelog (#15) * Bump version to 1.0.0 (#16) * Fix year in license headers (#18) * Add README description (#20) * Update version to 1.0.1 (#21) * Read new TRAINING_JOB_NAME environment variable during training (#34) * Bump version to 1.0.2 and update Changelog (#37) * Move processing of requirements file out to the specific container. (#39) * Bump version to 1.0.3 and update Changelog (#42) * Change module name to string in __all__ (#50) * Hardcode special case for tuning job hyperparameter (#54) * Use strip() for more readability (#55) This change is a small improvement upon #54 * Bump version to 1.0.4 (#56)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Tuning jobs inject a hyperparameter that won't be serialized as a well-formed JSON - our containers expect hyperparameters to be serialized, even though they may not be. This change is a hack to take care of the tuning job hyperparameter, but in the future we should probably write some more general logic (see the TODO note at the beginning of the method)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.