Skip to content

Conversation

@enageshwari
Copy link
Contributor

Description

  • Add download script for Amazon Q artifacts with retry logic and validation
  • Add URL extraction utility for Amazon Q chat URLs from S3 manifest
  • Update Dockerfiles to include Amazon Q integration with proper artifact placement
  • Improve build process with better error handling and logging
  • Add comprehensive test coverage for Amazon Q functionality
  • Enhance package management and dependency resolution
  • Apply checkstyle fixes (black, isort, autoflake)

Targeted versions

  • SMD 2.9.5+ and future 3.5+ releases. See [4] for 2.9.5 patch PR.
    • Verified with SMD team that build artifacts present in patch PR above need not be included for 'main' merge.

Type of Change

  • Image update - Bug fix
  • Image update - New feature
  • Image update - Breaking change
  • SMD image build tool update
  • Documentation update

Release Information

Does this change need to be included in patch version releases? By default, any pull requests will only be added to the next SMD image minor version release once they are merged in template folder. Only critical bug fix or security update should be applied to new patch versions of existed image minor versions.

  • Yes (Critical bug fix or security update)
  • No (New feature or non-critical change)
  • N/A (Not an image update)

If yes, please explain why:
[Explain the criticality of this change and why it should be included in patch releases]
Private subnet use case is broken for SMUS JL users with SMD 2.9. More details in [1]

How Has This Been Tested?

  • Existing unit tests passed
  • New unit tests passed
  • Functionality test:
    • Test SMD changes:
      - Followed instructions in CONTRIBUTING.md to test in 2.9.5 patch and 3..5.0 releases in local. Verified required artifacts are in right folder with right permissions and SMUS JL can use it. Check test results in [2].
      - Note: For patch versions, artifacts are copied from base version. Changes on Dockerfile are not automatically applied. Hence updated Dockerfile in 2.9.5 build artifacts with required changes and added required script for the build to go through.
    • Test if SMD changes will bring desired result to address [1]:
      - Steps followed for testing: Built image for 2.9.5 patch version -> created a container -> verified required artifacts are present with required permissions -> Reinstalled the SM GenAI JL extn with fix to pull from given dir. It worked. Test results in [2]

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Test Screenshots (if applicable):

Screenshot 2025-10-07 at 12 39 08 PM

Related Issues

See [1]

References

[1] Issue: https://tiny.amazon.com/zmh6meka/tcorpamazP302
[2] Test Results: https://tiny.amazon.com/2v58bfag/drivcorpamazfoldSMUSFail
[3] Proj doc: https://tiny.amazon.com/1fcqel5xg/quip9QzGSupp
[4] #946

- Add download script for Amazon Q artifacts with retry logic and validation
- Add URL extraction utility for Amazon Q chat URLs from S3 manifest
- Update Dockerfiles to include Amazon Q integration with proper artifact placement
- Improve build process with better error handling and logging
- Add comprehensive test coverage for Amazon Q functionality
- Enhance package management and dependency resolution
- Apply checkstyle fixes (black, isort, autoflake)
@enageshwari enageshwari requested a review from a team as a code owner October 20, 2025 23:03
@TRNWWZ TRNWWZ merged commit 6fbb068 into aws:main Oct 21, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants