Fix help message for auto-resume and max-retry options #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswudi
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
xiaoxshe
approved these changes
Sep 10, 2024
xiaoxshe
pushed a commit
to xiaoxshe/sagemaker-hyperpod-cli
that referenced
this pull request
Dec 4, 2024
* update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding
xiaoxshe
added a commit
that referenced
this pull request
Dec 4, 2024
* add recipes feature for distributed training * improve unit test coverage for recipes feature * add support recipes along with command line args * add recipes * Crescendo helm chart for role and rolebinding (#17) * update the helm chart to create team level roles and bindings * revert unrelated changes * Rename quotaAllocationTarget to computeQuotaTarget * remove kueue related resources from helm chart * Remove parameters of kueue from chart * flip the team role creation to false * Revise readme to add instructions to create the role and binding * add changelog for distributed training * change to public submodules * QuotaAllocation support for Hyperpod CLI (#12) * QuotaAllocation support for Hyperpod CLI --------- Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com> * Remove custom_launcher folder * sync with mainline --------- Co-authored-by: cansun <80425164+can-sun@users.noreply.github.com> Co-authored-by: Amazon GitHub Automation <54958958+amazon-auto@users.noreply.github.com> Co-authored-by: Song Jiang <jiangsongbz@gmail.com> Co-authored-by: Baiyang Li <baiyanl@amazon.com> Co-authored-by: baiyli <105086653+baiyli@users.noreply.github.com> Co-authored-by: Can Sun <sucan@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The help message for auto-resume is incorrect.
Description of changes:
HyperPod resilience job auto resume supports in all namespaces.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.