[Inference Operator] Update sample CRD files for v3.1 features#413
Open
zicanl-amazon wants to merge 1 commit intoaws:mainfrom
Open
[Inference Operator] Update sample CRD files for v3.1 features#413zicanl-amazon wants to merge 1 commit intoaws:mainfrom
zicanl-amazon wants to merge 1 commit intoaws:mainfrom
Conversation
Replace 6 stale v1alpha1-era samples with 20 curated v1 samples covering: - HuggingFace model source (TGI, vLLM, SGLang runtimes, prefetch on/off) - Kubernetes volume model source - ServiceAccount (IRSA) support - NVMe + S3 prefetch patterns (on/off, with/without fallback) - BYO TLS certificate - Health probes (liveness/readiness) - Multi-node inference - Node affinity scheduling - Intelligent routing with KV cache (L1, L1+L2) Internal-only samples excluded (DPD, test fixtures, benchmarks). All account IDs, personal bucket names, and internal hostnames sanitized. Signed-off-by: Zican Li <zicanl@amazon.com>
zicanl-amazon
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Replace 6 stale v1alpha1-era sample files with 20 curated v1 samples from the internal operator repo.
The existing samples did not reflect any of the new CRD features added in v3.1 (PR #412). The new samples demonstrate all customer-facing v3.1 features:
Internal-only samples excluded (DPD, test fixtures, benchmarks).
All account IDs, personal bucket names, and internal hostnames sanitized with
<PLACEHOLDER>values.Before/After UX
Before:
6 outdated samples from v1alpha1 era — no huggingface, no kubernetesVolume, no serviceAccount, no dataCapture, no health probes.
After:
20 samples covering all customer-facing v3.1 features with clear comments, prerequisites, and placeholder values for easy customization.
How was this change tested?
Sample files are static YAML documentation — no runtime behavior. Validated:
apiVersion: inference.sagemaker.aws.amazon.com/v1Are unit tests added?
N/A — sample files are documentation/examples, not executable code.
Are integration tests added?
N/A — sample files are documentation/examples, not executable code.
Reviewer Guidelines
One of the following must be true: