change: allow ModelMonitor and Processor to take IAM role names (in addition to ARNs) #1150

laurenyu · 2019-12-05T19:18:39Z

Issue #, if available:

Description of changes:
Our other classes make use of Session.expand_role to accept either a name or an ARN for the AWS IAM role. This change is to make that consistent with our new classes.

This change also removes some hardcoded AWS account IDs and regions from some integration tests to allow the tests to be run in different AWS accounts and/or regions.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ddition to ARNs) This change also removes some hardcoded AWS account IDs and regions from some integration tests.

sagemaker-bot · 2019-12-05T19:22:08Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:29:54Z

AWS CodeBuild CI Report

Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:39:14Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:42:10Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:45:16Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:48:28Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:53:57Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T19:56:18Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T20:05:11Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T21:39:43Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T21:55:50Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T21:59:43Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T22:02:17Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T22:13:59Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T22:23:08Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T22:57:37Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T23:09:51Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-05T23:21:04Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-06T19:11:13Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-06T19:19:57Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-06T22:15:04Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-06T22:29:01Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-06T22:36:45Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-07T01:30:46Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-07T01:46:43Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-07T01:55:13Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T05:44:11Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T05:58:01Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T06:05:53Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T06:12:55Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T06:28:56Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T06:36:11Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T06:45:33Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T06:59:28Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-08T07:07:35Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knakad · 2019-12-09T17:26:28Z

tests/integ/test_model_monitor.py

 INTEG_TEST_MONITORING_OUTPUT_BUCKET = "integ-test-monitoring-output-bucket"

-FIVE_MINUTE_CRON_EXPRESSION = "cron(0 0/5 * ? * * *)"
+FIVE_MINUTE_CRON_EXPRESSION = "cron(0 5 * ? * *)"


sagemaker-bot · 2019-12-09T19:08:25Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-09T19:23:28Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2019-12-09T19:30:48Z

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: allow ModelMonitor and Processor to take IAM role names (in a…

c652e64

…ddition to ARNs) This change also removes some hardcoded AWS account IDs and regions from some integration tests.

Remove unused test constants

6826d12

ChoiByungWook previously approved these changes Dec 5, 2019

View reviewed changes

update unit tests

bb99417

laurenyu dismissed ChoiByungWook’s stale review via bb99417 December 5, 2019 19:36

ChoiByungWook self-requested a review December 5, 2019 19:38

ChoiByungWook previously approved these changes Dec 5, 2019

View reviewed changes

fix integ tests

35ac28a

laurenyu dismissed ChoiByungWook’s stale review via 35ac28a December 5, 2019 21:34

Merge branch 'master' into hardcoded-acct-integ-tests

159467c

Merge branch 'master' into hardcoded-acct-integ-tests

5d9b71c

ChoiByungWook self-requested a review December 5, 2019 23:22

fix integ tests

cd0126b

fix a couple more spots

7e5eb89

laurenyu force-pushed the hardcoded-acct-integ-tests branch from a77c0d3 to 7e5eb89 Compare December 8, 2019 05:38

fix cron expression

7d46f6e

fix logic and try new cron expression

e200bb3

knakad suggested changes Dec 9, 2019

View reviewed changes

try again

b2bf256

knakad approved these changes Dec 9, 2019

View reviewed changes

ChoiByungWook merged commit 0838bf0 into aws:master Dec 9, 2019

laurenyu deleted the hardcoded-acct-integ-tests branch December 9, 2019 20:10

change: allow ModelMonitor and Processor to take IAM role names (in addition to ARNs) #1150

change: allow ModelMonitor and Processor to take IAM role names (in addition to ARNs) #1150

Uh oh!

Conversation

laurenyu commented Dec 5, 2019

Merge Checklist

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 5, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 6, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 6, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 6, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 6, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 6, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 7, 2019

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Dec 7, 2019