feat(train): Add wait_timeout parameter to train()#5786
Merged
mollyheamazon merged 2 commits intoaws:masterfrom Apr 22, 2026
Merged
feat(train): Add wait_timeout parameter to train()#5786mollyheamazon merged 2 commits intoaws:masterfrom
mollyheamazon merged 2 commits intoaws:masterfrom
Conversation
Updated trainers: SFT, DPO, RLAIF, RLVR, and BaseTrainer.
gauravmadarkal
had a problem deploying
to
manual-approval
GitHub Actions
Error
gauravmadarkal
had a problem deploying
to
manual-approval
GitHub Actions
Error
joshuatowner
approved these changes
Apr 22, 2026
Contributor
joshuatowner
left a comment
joshuatowner
left a comment
There was a problem hiding this comment.
should we add any tests (if straightforward)
gauravmadarkal
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
gauravmadarkal
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
mollyheamazon
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updated trainers: SFT, DPO, RLAIF, RLVR, and BaseTrainer.
Added wait_timeout parameter to train(). Right now train defaults to 3000s wait timeout, adding a wait_timeout parameter helps making this configurable by the caller.