fix: potential s3 path traversal#5804
Merged
zhaoqizqwang merged 3 commits intoaws:masterfrom Apr 29, 2026
Merged
Conversation
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mujtaba1747
requested changes
Apr 28, 2026
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
Collaborator
Author
|
The failed integ tests in sagemaker-core and sagemaker-train are not related to code change in this PR |
mujtaba1747
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix potential s3 path traversal by using
realpath()and containment checks before every S3-to-local file writeBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.