Unskip sagemaker serve integration tests#5810
Merged
mujtaba1747 merged 9 commits intoaws:masterfrom May 4, 2026
Merged
Conversation
…s from deleting endpoint
nargokul
approved these changes
May 4, 2026
nargokul
approved these changes
May 4, 2026
nargokul
approved these changes
May 4, 2026
mollyheamazon
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #5802
Description of changes: Fix skipped tests in sagemaker-serve
test_model_customization_deployment.py
Problem:
cleanup_e2e_endpoints is a session-scoped fixture, but under pytest-xdist each worker gets its own session. This means multiple workers independently call Endpoint.get_all() and delete every e2e-* endpoint — including endpoints that another worker just created and is actively using.
Observed failure: Test running on worker gw2 deploys e2e-1777420521-4224, its base inference component goes InService, then a different worker's cleanup deletes it. The test on gw2 then fails when it tries to Endpoint.get() the endpoint it just created.
The teardown path had the same problem — it ran the same Endpoint.get_all() + delete loop after tests, risking a second round of collisions.
Changes:
Only delete e2e endpoints older than 24 hrs.
test_optimize_integration.py
Problem: Test kept failing because it used to run in us-east-2. And the test failed due to race condition: Other tests initializing the singleton SageMakerClient class in different region causing resource not found errors in test_optimize_integration,
Changes: Ensure tests run in a single region. Parameterized image uri in test_optimize_integration so it can run in us-west-2 and ported to other regions in future.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.