fix: unskip evaluator integ test classes in sm-train#5854
Merged
Conversation
…None metrics handling
cc1fdd9 to
ab553e6
Compare
Collaborator
Author
mujtaba1747
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Some of the integration tests were passed, working on unskipping them to improve test cover rate.
Description
This PR unskips evaluator integration test classes in
sagemaker-trainthat were temporarily skipped during a file relocation and never re-enabled.Changes Summary
127794381277943812779438f58d8368f58d8368107e5fbe107e5fbepass— placeholder for future implementation)3ce1324c,ab553e6c107e5fbeb1c094e0@pytest.mark.xdist_groupto prevent pipeline concurrency conflictsTest Results
test_benchmark_evaluation_nova_modelandtest_benchmark_evaluation_base_model_onlytest_custom_scorer_evaluation_full_flow(intermittent pipeline concurrency issue)test_benchmark_evaluation_nova_model— requires cross-account us-east-1 infrastructuretest_benchmark_evaluation_base_model_only— pipeline creation returns None (under investigation)New Unit Tests Added
test_llm_as_judge_evaluator_builtin_metrics_only_no_custom— verifies evaluator handlescustom_metrics=Nonecorrectlytest_llm_as_judge_evaluator_custom_metrics_only_no_builtin— verifies evaluator handlesbuiltin_metrics=Nonecorrectly