fix: harden tar extraction path validation#5905
Open
dfgvaetyj3456356-hash wants to merge 1 commit into
Open
Conversation
f8fbcae to
911b905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tightens the Python < 3.12 fallback path validation used by
custom_extractall_tarfile.The fallback now validates tar members against the actual extraction directory with
os.path.commonpath()instead of a raw string-prefix comparison. This avoids accepting paths that merely share the same textual prefix as the target directory, and keeps the fallback behavior closer to the Python 3.12+filter="data"path.The fallback also skips special file members, matching another important
filter="data"safety behavior.Testing
Result:
3 passedfor the focused extraction tests.