Breaking: Update sagemaker-training version >=5.0.0 #260
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| 'Programming Language :: Python :: 3.9', | ||
| ], | ||
|
|
||
| install_requires=['retrying', 'sagemaker-training>=4.3.0,<=4.8.3', 'six>=1.12.0'], |
There was a problem hiding this comment.
do we need <6.0.0? if we keep version backward compatible, it will be good to always try to pull latest?
There was a problem hiding this comment.
Given the base toolkit is now at v5, I don't think that it is a guarantee that we would not have a v6
There was a problem hiding this comment.
Yes, I mean, shouldn't we keep base toolkit backward compatible so there's no restriction to upgrade to latest version even if we published V6?
There was a problem hiding this comment.
I know what you mean, but for V5 our breaking release was not due to the base toolkit change itself, it was from a breaking dependency. Major version releases are for breaking non-backwards compatible changes. Otherwise if the change is backwards compatible that should come as a minor or patch release for the V5 major version
* Breaking: Update sagemaker-training version >=5.0.0 * update test dependency * Add latest version and python version to README * fix GitHub README shield badges * fix tests
3 participants
Issue #, if available:
Description of changes:
sagemaker-training-toolkittosagemaker-training>=5.0.0,<6.0.0which includes breaking changesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.