upgrading pyarrow to fix the numpy 1.21.0 broken changes and fixing integ tests#111
Closed
NikhilRaverkar wants to merge 2 commits intomasterfrom
Closed
upgrading pyarrow to fix the numpy 1.21.0 broken changes and fixing integ tests#111NikhilRaverkar wants to merge 2 commits intomasterfrom
NikhilRaverkar wants to merge 2 commits intomasterfrom
Conversation
secastillo
reviewed
May 2, 2022
| ' --mount type=volume,source=dynamic_endpoint_module_volume,target=/user_module,readonly' | ||
| # ' --mount type=volume,source=dynamic_endpoint_model_volume,target=/opt/ml/model,readonly' | ||
| # ' --mount type=volume,source=dynamic_endpoint_module_volume,target=/user_module,readonly' | ||
| ' -v {}:/opt/ml/model' |
Contributor
There was a problem hiding this comment.
for my understanding, why were these arguments module_dir and model_dir added with these changes?
Author
There was a problem hiding this comment.
Sorry for the confusion, these changes are unrelated to the pyarrow upgrade. The integ tests are currently broken so this change is fixing the integ tests as well. Updated description and title
dewan-c
reviewed
May 2, 2022
| @@ -55,19 +55,24 @@ def modulevolume(): | |||
|
|
|||
| @pytest.fixture(scope='module', autouse=True) | |||
Contributor
There was a problem hiding this comment.
Do we also want to update the version in test setup(tox.ini)?
Author
|
Closing this since PR#110 is upgrading the version. Will create a new PR for the new version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed pyarrow version
Testing:
Verified that error does not exist anymore after the upgrade:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.