Add instance_type parameter to test functions #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxshe
approved these changes
Jun 23, 2025
mrpic-amzn
force-pushed
the
feature/test-improvements
branch
from
844f984 to
d47b2c1
Compare
mrpic-amzn
force-pushed
the
feature/test-improvements
branch
from
d47b2c1 to
9d5c126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Some newer AWS regions do not support
ml.c5.xlargeinstance types (e.g. KUL). By making the instance-type a parameter, we will be able to modify our release pipeline to change the instance-type used in different regions. This will allow our automation to release to new regions.Testing:
make lintmake test-sagemakerBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.