Skip to content

Conversation

@ChoiByungWook
Copy link
Contributor

@ChoiByungWook ChoiByungWook commented Apr 20, 2018

Issue #, if available:
#40

Description of changes:
Change type of seed parameter from double to int.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ChoiByungWook ChoiByungWook requested a review from yangaws April 20, 2018 20:21
Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@yangaws yangaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault. You need to change pyspark as well.

@ChoiByungWook ChoiByungWook merged commit ebe6733 into aws:master Apr 23, 2018
@ChoiByungWook ChoiByungWook deleted the xgboost_fix branch April 23, 2018 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants