Skip to content

Fix seed parameter for XGBoost #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChoiByungWook merged 2 commits into from
Apr 23, 2018
Merged

Fix seed parameter for XGBoost #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8373c3
Fix seed parameter for XGBoost
Apr 20, 2018
0be687e
Fix for PySpark
Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ CHANGELOG
========

* pyspark: SageMakerModel: Fix bugs in creating model from training job, s3 file and endpoint

* spark/pyspark: XGBoostSageMakerEstimator: Fix seed hyperparameter to use correct type (Int)

1.0.4
=====
Expand Down
2 changes: 1 addition & 1 deletion sagemaker-pyspark-sdk/src/sagemaker_pyspark/algorithms/XGBoostSageMakerEstimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ class XGBoostSageMakerEstimator(SageMakerEstimatorBase):
seed = Param(
Params._dummy(), "seed",
"Random number seed",
typeConverter=TypeConverters.toFloat)
typeConverter=TypeConverters.toInt)

num_round = Param(
Params._dummy(), "num_round",
Expand Down
6 changes: 3 additions & 3 deletions ...cala/com/amazonaws/services/sagemaker/sparksdk/algorithms/XGBoostSageMakerEstimator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,8 @@ private[algorithms] trait XGBoostParams extends Params {
/** Random number seed.
* Default = 0
*/
val seed: DoubleParam = new DoubleParam(this, "seed", "Random number seed.")
def getSeed: Double = $(seed)
val seed: IntParam = new IntParam(this, "seed", "Random number seed.")
def getSeed: Int = $(seed)

/**
* Number of rounds for gradient boosting. Must be >= 1. Required.
Expand Down Expand Up @@ -614,7 +614,7 @@ class XGBoostSageMakerEstimator(

def setEvalMetric(value: String) : this.type = set(evalMetric, value)

def setSeed(value: Double) : this.type = set(seed, value)
def setSeed(value: Int) : this.type = set(seed, value)

def setNumRound(value: Int) : this.type = set(numRound, value)

Expand Down
4 changes: 2 additions & 2 deletions ...com/amazonaws/services/sagemaker/sparksdk/algorithms/XGBoostSageMakerEstimatorTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ class XGBoostSageMakerEstimatorTests extends FlatSpec with Matchers with Mockito


it should "setSeed" in {
val seed = 10.0
val seed = 10
estimator.setSeed(seed)
assert(seed == estimator.getSeed)
}
Expand Down Expand Up @@ -381,7 +381,7 @@ class XGBoostSageMakerEstimatorTests extends FlatSpec with Matchers with Mockito
"objective" -> "reg:logistic",
"base_score" -> "0.5",
"eval_metric" -> "mae",
"seed" -> "0.0"
"seed" -> "0"
)

assert(hyperParamMap.asJava == estimator.makeHyperParameters())
Expand Down