Skip to content

Conversation

@yangaws
Copy link
Contributor

@yangaws yangaws commented Nov 6, 2018

Issue #, if available:

Description of changes:
Add region support to BOM/SIN/LHR/YUL/SFO
Update related unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

laurenyu
laurenyu previously approved these changes Nov 6, 2018
@codecov-io
Copy link

codecov-io commented Nov 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f242ef0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   92.31%           
=========================================
  Files             ?       52           
  Lines             ?     3226           
  Branches          ?       88           
=========================================
  Hits              ?     2978           
  Misses            ?      248           
  Partials          ?        0
Impacted Files Coverage Δ
...gemaker/sparksdk/algorithms/ImageURIProvider.scala 97.91% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f242ef0...e7d03d9. Read the comment docs.

Regions.EU_CENTRAL_1.getName -> "353608530281",
Regions.AP_SOUTHEAST_2.getName -> "297031611018"
Regions.AP_SOUTHEAST_2.getName -> "297031611018",
Regions.GovCloud.getName -> "226302683700",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@yangaws yangaws merged commit 64c41af into aws:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants