Raise InvalidResourceException when UsagePlan type is not correct #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoffa
reviewed
Nov 1, 2021
Contributor
There was a problem hiding this comment.
Don't we have some way (functional tests?) to pass a template and ensure it fails some expected manner? Instead of requiring all this mocking.
Contributor
Author
There was a problem hiding this comment.
Good call. Added one for the invalid template I intended to fix.
hoffa
approved these changes
Nov 1, 2021
aahung
force-pushed
the
fix-usage-plan-validation
branch
4 times, most recently
from
30e89e1 to
79cc24c
Compare
marekaiv
reviewed
Nov 2, 2021
Contributor
There was a problem hiding this comment.
(minor) it might be more user-friendly to tell them the expected type "UsagePlan" must be a dictionary rather than just saying it's invalid.
marekaiv
approved these changes
Nov 2, 2021
aahung
force-pushed
the
fix-usage-plan-validation
branch
from
79cc24c to
aee2d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.