feat: fully support Python 3.14#3913
Conversation
|
There's a failure because in theory this commit has a "breaking change" because I deleted the function that checked for compatibility with Python 3.14. I could add it again, but of course this is not something that customers would really call when using SAM, so I think it's okay to just delete it here, and potentially override the failure in the check to be able to merge. (Unless someone has a different opinion) |
|
humm, seems v2.13.3 is messing things up. And it only works correctly in python3.14. Do we see this as a potential risk? |
|
FYI cfn-lint >= 1.49 stopped supporting python3.14. |
|
Confirmed all these error is comming from cfn-lint 1.49.1 All the error is comming from this cfn-lint update: These new rule start linting on our test resource names |
|
Seems the most straightforward fix is to add Alternative is to make all test resource naming comply. But that's a huge effort |
|
I think cfn-lint doesn't work correctly in Python 3.14 precisely because it has this package as its dependency It's kind of a cycle, where they depend on us, but we depend on them too. Hopefully we can merge this soon so everyone can be happy with Python 3.14. |
- Update to Pydantic >= 2.13, which added support for Python 3.14 in the legacy v1 version included https://pypi.org/project/pydantic/2.13.0/ - Remove previous checks that make the code fail in Python 3.14 for some functionality.
Update to Pydantic >= 2.13, which added support for Python 3.14 in the legacy v1 version included (that we're using)
https://pypi.org/project/pydantic/2.13.0/
Remove previous checks that make the code fail in Python 3.14 for some functionality.
Issue #, if available
#3831
Description of changes
The new version of Pydantic allows its v1 to support Python 3.14, so we can support it without having to migrate to v2 yet.
Description of how you validated changes
make prChecklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.