Tell PyPI long_description is Markdown #610
Conversation
Fixes aws#609. This will apply from the next release. Cf aws/aws-xray-sdk-python#101
jlhood
left a comment
jlhood
left a comment
There was a problem hiding this comment.
Thanks for fixing this! If you haven't already, you should consider signing up for Hacktoberfest so this PR counts towards it. 😊
|
This is awesome! I didn't even know this was an option and I was dreading having to convert all our files to RST. I'll approve now but will wait for you to respond before merging in case you want to sign up for Hacktoberfest like James mentioned |
|
Changed base branch to release/1.8.0 so it gets picked up in our upcoming release |
keetonian
left a comment
keetonian
left a comment
There was a problem hiding this comment.
1.7.0 looked horrible on pypi when I released it, thank you for fixing this!
|
I think this is the first PR to receive 3 approvals (and so quickly!). #itsthesimplethings |
|
I signed up for hacktoberfest but opening a PR counts rather than merges |
|
Also as AWS employees should you really promote a Microsoft + DigitalOcean collaboration? |
|
There's free swag involved and they gave it a cool name, so why not? I'll go ahead and merge this in, thanks again! |
|
1.8.0 still look ugly: https://pypi.org/project/aws-sam-translator/ Maybe there's a problem with the markdown syntax so that PyPI can't render it? :/ |
4 participants
Issue #, if available: #609
Description of changes:
Fixes #609. This will apply from the next release.
Cf aws/aws-xray-sdk-python#101
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.