fix: ensuring that headers are case insensitive #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great catch! Thank you for the contribution! |
jogep
pushed a commit
to jogep/aws-serverless-java-container
that referenced
this pull request
Dec 8, 2020
* fix: ensuring that headers are case insensitive * fix: updating spring version in ci Co-authored-by: Kevin Sewell <kevin@gometroapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the header map in HttpApiV2ProxyRequest cannot handle all lower-case headers. I replaced the standard HashMap with a TreeMap using the String.CASE_INSENSITIVE_ORDER comparator to ensure accommodate this.
This is a problem because headers arrive from the API Gateway in all lowercase, but in AwsHttpApiV2SecurityContext, for example, we checking for the capitalised Authorization header.
By submitting this pull request