Skip to content

fix: ensuring that headers are case insensitive #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020
Merged

fix: ensuring that headers are case insensitive #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3dd77d
fix: ensuring that headers are case insensitive
Oct 1, 2020
9660dcb
fix: updating spring version in ci
Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/continuous-integration-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ jobs:
# Spring core 5.2 and above. SpringBoot 1.5 is deprecated
run: ./gha_build.sh spring true true -Djacoco.minCoverage=0.4
- name: Build Spring 4.3
run: ./gha_build.sh spring false false -Dspring.version=4.3.25.RELEASE -Dspring-security.version=4.2.13.RELEASE
run: ./gha_build.sh spring false false -Dspring.version=4.3.29.RELEASE -Dspring-security.version=4.2.18.RELEASE
- name: Build Spring 5.0
run: ./gha_build.sh spring false false -Dspring.version=5.0.16.RELEASE -Dspring-security.version=5.0.14.RELEASE
run: ./gha_build.sh spring false false -Dspring.version=5.0.19.RELEASE -Dspring-security.version=5.0.18.RELEASE
- name: Build Spring 5.1
run: ./gha_build.sh spring false false -Dspring.version=5.1.14.RELEASE -Dspring-security.version=5.1.8.RELEASE
run: ./gha_build.sh spring false false -Dspring.version=5.1.18.RELEASE -Dspring-security.version=5.1.12.RELEASE

build_springboot2:
name: Build and test SpringBoot 2
Expand All @@ -63,9 +63,9 @@ jobs:
- name: Build latest
run: ./gha_build.sh springboot2 true true
- name: Build Spring Boot 2.0
run: ./gha_build.sh springboot2 false false -Dspringboot.version=2.0.9.RELEASE -Dspring.version=5.0.16.RELEASE -Dspringsecurity.version=5.0.14.RELEASE
run: ./gha_build.sh springboot2 false false -Dspringboot.version=2.0.9.RELEASE -Dspring.version=5.0.19.RELEASE -Dspringsecurity.version=5.0.18.RELEASE
- name: Build Spring Boot 2.1
run: ./gha_build.sh springboot2 false false -Dspringboot.version=2.1.12.RELEASE -Dspring.version=5.1.13.RELEASE -Dspringsecurity.version=5.1.8.RELEASE
run: ./gha_build.sh springboot2 false false -Dspringboot.version=2.1.17.RELEASE -Dspring.version=5.1.18.RELEASE -Dspringsecurity.version=5.1.12.RELEASE

build_struts2:
name: Build and test Struts 2
Expand Down
2 changes: 1 addition & 1 deletion ...c/main/java/com/amazonaws/serverless/proxy/internal/testutils/AwsProxyRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ public HttpApiV2ProxyRequest toHttpApiV2Request() {
if (request.getMultiValueHeaders() != null && request.getMultiValueHeaders().containsKey(HttpHeaders.COOKIE)) {
req.setCookies(Arrays.asList(request.getMultiValueHeaders().getFirst(HttpHeaders.COOKIE).split(";")));
}
req.setHeaders(new HashMap<>());
req.setHeaders(new TreeMap<>(String.CASE_INSENSITIVE_ORDER));
if (request.getMultiValueHeaders() != null) {
request.getMultiValueHeaders().forEach((key, value) -> req.getHeaders().put(key, value.get(0)));
}
Expand Down
2 changes: 1 addition & 1 deletion aws-serverless-java-container-spring/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</parent>

<properties>
<spring.version>5.2.5.RELEASE</spring.version>
<spring.version>5.2.9.RELEASE</spring.version>
<springboot.version>1.5.22.RELEASE</springboot.version>
<spring-security.version>5.2.2.RELEASE</spring-security.version>
</properties>
Expand Down
4 changes: 2 additions & 2 deletions aws-serverless-spring-archetype/src/main/resources/archetype-resources/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ repositories {

dependencies {
compile (
'org.springframework:spring-webmvc:5.2.5.RELEASE',
'org.springframework:spring-context:5.2.5.RELEASE',
'org.springframework:spring-webmvc:5.2.9.RELEASE',
'org.springframework:spring-context:5.2.9.RELEASE',
'com.amazonaws.serverless:aws-serverless-java-container-spring:[1.0,)',
'org.apache.logging.log4j:log4j-core:2.8.2',
'org.apache.logging.log4j:log4j-api:2.8.2',
Expand Down
2 changes: 1 addition & 1 deletion aws-serverless-spring-archetype/src/main/resources/archetype-resources/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<properties>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<spring.version>5.2.5.RELEASE</spring.version>
<spring.version>5.2.9.RELEASE</spring.version>
<junit.version>4.12</junit.version>
<log4j.version>2.8.2</log4j.version>
</properties>
Expand Down
4 changes: 2 additions & 2 deletions samples/spring/pet-store/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ repositories {

dependencies {
compile (
'org.springframework:spring-webmvc:5.2.5.RELEASE',
'org.springframework:spring-context:5.2.5.RELEASE',
'org.springframework:spring-webmvc:5.2.9.RELEASE',
'org.springframework:spring-context:5.2.9.RELEASE',
'com.amazonaws.serverless:aws-serverless-java-container-spring:[1.0,)',
'org.apache.logging.log4j:log4j-core:2.8.2',
'org.apache.logging.log4j:log4j-api:2.8.2',
Expand Down
2 changes: 1 addition & 1 deletion samples/spring/pet-store/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<properties>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<spring.version>5.2.5.RELEASE</spring.version>
<spring.version>5.2.9.RELEASE</spring.version>
<junit.version>4.12</junit.version>
<log4j.version>2.13.3</log4j.version>
</properties>
Expand Down