- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.8k
 
C++: Updates to SNS and SQS metadata and Readme files #5249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            rlhagerm
  merged 3 commits into
  awsdocs:main
from
meyertst-aws:5232-c++-add-sns_publish_with_attribute-metadata
  
      
      
   
  Aug 11, 2023 
      
    
                
     Merged
            
            C++: Updates to SNS and SQS metadata and Readme files #5249
                    rlhagerm
  merged 3 commits into
  awsdocs:main
from
meyertst-aws:5232-c++-add-sns_publish_with_attribute-metadata
  
      
      
   
  Aug 11, 2023 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    f0f6487    to
    2dd6665      
    Compare
  
    
              
                    cpyle0819
  
              
              reviewed
              
                  
                    Aug 10, 2023 
                  
              
              
            
            
        
          
                cpp/example_code/cross-service/topics_and_queues/messaging_with_topics_and_queues.cpp
          
            Show resolved
            Hide resolved
        
      
              
                    cpyle0819
  
              
              reviewed
              
                  
                    Aug 10, 2023 
                  
              
              
            
            
              
                    cpyle0819
  
              
              reviewed
              
                  
                    Aug 10, 2023 
                  
              
              
            
            
              
                    cpyle0819
  
              
              requested changes
              
                  
                    Aug 10, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Steve. I noticed a few oddities in the readmes. Left some comments.
              
                    cpyle0819
  
              
              approved these changes
              
                  
                    Aug 11, 2023 
                  
              
              
            
            
7e0ec52    to
    303f915      
    Compare
  
    
              
                    rlhagerm
  
              
              requested changes
              
                  
                    Aug 11, 2023 
                  
              
              
            
            
              
                    rlhagerm
  
              
              approved these changes
              
                  
                    Aug 11, 2023 
                  
              
              
            
            
303f915    to
    2e401d3      
    Compare
  
    
    
  meyertst-aws 
      added a commit
        to meyertst-aws/aws-doc-sdk-examples
      that referenced
      this pull request
    
      Aug 15, 2023 
    
    
      
  
    
      
    
  
* Add publish with attributes metadata
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    C++
  This issue relates to the AWS SDK for C++ 
  
    On Call Review complete
  On call review complete 
  
    Text Review not needed
  This contains no text which needs review 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
I added a sns_Publish_WithAttribute to sns_metadata.yaml
I added the SOS tag to the Publish and subscribe workflow
I updated the READMEs for SNS and SQS with WRITEME
I made minor changes to the cross_metadata.yml to support WRITEME
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.