Skip to content

Conversation

@meyertst-aws
Copy link
Contributor

I added a sns_Publish_WithAttribute to sns_metadata.yaml
I added the SOS tag to the Publish and subscribe workflow
I updated the READMEs for SNS and SQS with WRITEME
I made minor changes to the cross_metadata.yml to support WRITEME


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added the C++ This issue relates to the AWS SDK for C++ label Aug 10, 2023
@meyertst-aws meyertst-aws requested a review from a team August 10, 2023 19:08
@meyertst-aws meyertst-aws self-assigned this Aug 10, 2023
@meyertst-aws meyertst-aws requested review from cpyle0819 and removed request for a team August 10, 2023 19:08
@meyertst-aws meyertst-aws force-pushed the 5232-c++-add-sns_publish_with_attribute-metadata branch from f0f6487 to 2dd6665 Compare August 10, 2023 19:11
Copy link
Contributor

@cpyle0819 cpyle0819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Steve. I noticed a few oddities in the readmes. Left some comments.

@meyertst-aws meyertst-aws added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review labels Aug 11, 2023
@meyertst-aws meyertst-aws force-pushed the 5232-c++-add-sns_publish_with_attribute-metadata branch from 7e0ec52 to 303f915 Compare August 11, 2023 13:40
@rlhagerm rlhagerm changed the title cpp_sns_publish_with_attributes C++: Updates to SNS and SQS metadata and Readme files Aug 11, 2023
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 11, 2023
@rlhagerm rlhagerm force-pushed the 5232-c++-add-sns_publish_with_attribute-metadata branch from 303f915 to 2e401d3 Compare August 11, 2023 18:56
@rlhagerm rlhagerm merged commit 6435dfe into awsdocs:main Aug 11, 2023
meyertst-aws added a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Aug 15, 2023
@meyertst-aws meyertst-aws deleted the 5232-c++-add-sns_publish_with_attribute-metadata branch August 21, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Text Review not needed This contains no text which needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants