C++: Update hello_s3.cpp #5254
Merged
C++: Update hello_s3.cpp #5254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
the
Text Review not needed
meyertst-aws
approved these changes
Aug 14, 2023
rlhagerm
approved these changes
Aug 14, 2023
rlhagerm
added
On Call Review complete
Adding explicit authentication check. S3 allows anonymous requests. Due to an issue with the c++ sdk, if a user is not authenticated this method will return an unhelpful ‘0 buckets’ instead of a helpful ‘authentication issue’ message. Since this example is for new users, lets be more helpful. See https://sim.amazon.com/issues/search?q=status%3A(Open)+containingFolder%3A(f50eb8c1-3469-4bb5-a16e-a6535f0b3c31)+(annapan)&sort=lastUpdatedConversationDate+desc&selectedDocument=afec5f96-00d4-4c4e-88c7-84179f16feaf&id_token=eyJ0eXAiOiJKV1MiLCJhbGciOiJQUzI1NiIsIng1dSI6Imh0dHA6Ly9zZW50cnktcGtpLmFtYXpvbi5jb20vcHVibGlja2V5LzEzNDM4NTk4In0.eyJpc3MiOiJzZW50cnkuYW1hem9uLmNvbSIsInN1YiI6ImFubmFwYW5AQU5ULkFNQVpPTi5DT00iLCJhdWQiOlsiaHR0cHM6Ly9zaW0uYW1hem9uLmNvbTo0NDMiXSwiZXhwIjoxNjkxNTk2NTYyLCJpYXQiOjE2OTE1OTU2NjIsImF1dGhfdGltZSI6MTY5MTU4ODQwNSwibm9uY2UiOiI3N2M2MWI1NzU0M2VkYWQ5MDQ1ZTZkMWZjZGI1MmIwYjRkOTllYzQ4NzA2NjJjODkwZTU4Y2QzMmIzOTFhZDM3IiwiYW1yIjpbIm1mYSIsIm90cCIsInB3ZCJdLCJyZXFfaWQiOm51bGwsImp0aSI6Img4NFU0YWJ4R05IUmU4bVpiUzExVUE9PSIsInBvc3R1cmVfY2hlY2siOjB9.DCFinQSQh7xSUEndVqDtmvxsx2waD3_tjIuIooaMSO_15oZk7UNoFG-2ZJ-kaqNTKT2dp7tM3QN65QN0qm21-vDtOxRtzCcuxAEOU4mXpsUaUFKRMOIbXuKQsIbj_t8O65IP16x64jMYjzDyrB7Ojm75pcRFZGq8rMypbLT-KwTGMFDMv8e1aXDYW1G0i84-4e9ITy9vTYnABrhG8AsgmEQe1g5UANg9G2kpkxzhGOqA4fedxKiAoMaXypxrl1rvBUKMlBtj_oxqQy1m97twrw-zVNfaYBmRqyv2BropFkJQn5PjH4GyW9kWpbyMTEHwc5SCGzpa1HqI0_SwFC-lAg and https://quip-amazon.com/u7fzAhoT24rd/Anonymous-Auth-in-the-SDKs-with-S3 for more information.
meyertst-aws
pushed a commit
to meyertst-aws/aws-doc-sdk-examples
that referenced
this pull request
Aug 15, 2023
Update hello_s3.cpp Adding explicit authentication check. S3 allows anonymous requests. Due to an issue with the c++ sdk, if a user is not authenticated this method will return an unhelpful ‘0 buckets’ instead of a helpful ‘authentication issue’ message. Since this example is for new users, lets be more helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding explicit authentication check. S3 allows anonymous requests. Due to an issue with the c++ sdk, if a user is not authenticated this method will return an unhelpful ‘0 buckets’ instead of a helpful ‘authentication issue’ message. Since this example is for new users, lets be more helpful. See https://sim.amazon.com/issues/search?q=status%3A(Open)+containingFolder%3A(f50eb8c1-3469-4bb5-a16e-a6535f0b3c31)+(annapan)&sort=lastUpdatedConversationDate+desc&selectedDocument=afec5f96-00d4-4c4e-88c7-84179f16feaf&id_token=eyJ0eXAiOiJKV1MiLCJhbGciOiJQUzI1NiIsIng1dSI6Imh0dHA6Ly9zZW50cnktcGtpLmFtYXpvbi5jb20vcHVibGlja2V5LzEzNDM4NTk4In0.eyJpc3MiOiJzZW50cnkuYW1hem9uLmNvbSIsInN1YiI6ImFubmFwYW5AQU5ULkFNQVpPTi5DT00iLCJhdWQiOlsiaHR0cHM6Ly9zaW0uYW1hem9uLmNvbTo0NDMiXSwiZXhwIjoxNjkxNTk2NTYyLCJpYXQiOjE2OTE1OTU2NjIsImF1dGhfdGltZSI6MTY5MTU4ODQwNSwibm9uY2UiOiI3N2M2MWI1NzU0M2VkYWQ5MDQ1ZTZkMWZjZGI1MmIwYjRkOTllYzQ4NzA2NjJjODkwZTU4Y2QzMmIzOTFhZDM3IiwiYW1yIjpbIm1mYSIsIm90cCIsInB3ZCJdLCJyZXFfaWQiOm51bGwsImp0aSI6Img4NFU0YWJ4R05IUmU4bVpiUzExVUE9PSIsInBvc3R1cmVfY2hlY2siOjB9.DCFinQSQh7xSUEndVqDtmvxsx2waD3_tjIuIooaMSO_15oZk7UNoFG-2ZJ-kaqNTKT2dp7tM3QN65QN0qm21-vDtOxRtzCcuxAEOU4mXpsUaUFKRMOIbXuKQsIbj_t8O65IP16x64jMYjzDyrB7Ojm75pcRFZGq8rMypbLT-KwTGMFDMv8e1aXDYW1G0i84-4e9ITy9vTYnABrhG8AsgmEQe1g5UANg9G2kpkxzhGOqA4fedxKiAoMaXypxrl1rvBUKMlBtj_oxqQy1m97twrw-zVNfaYBmRqyv2BropFkJQn5PjH4GyW9kWpbyMTEHwc5SCGzpa1HqI0_SwFC-lAg and https://quip-amazon.com/u7fzAhoT24rd/Anonymous-Auth-in-the-SDKs-with-S3 for more information.
This pull request...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.