H2 cookie header field #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Apr 6, 2020
source/h2_decoder.c
Outdated
| return AWS_OP_ERR; | ||
| } | ||
|
|
||
| if (decoder->header_block_in_progress.cookies.len) { |
Contributor
There was a problem hiding this comment.
don't flush the cookie if the header block is malformed. Once we detect the header block is malformed we stop delivering individual headers.
That behavior would be more clear if we also moved the s_flush_pseudoheaders() call inside the if (!malformed) block. I thought it was simpler-looking to have that function do its own check, but it's obviously more confusing then helpful
graebm
approved these changes
Apr 6, 2020
source/h2_decoder.c
Outdated
| return AWS_OP_SUCCESS; | ||
| } | ||
| struct aws_http_header concatenated_cookie; | ||
| concatenated_cookie.name = aws_byte_cursor_from_c_str("cookie"); |
Contributor
There was a problem hiding this comment.
trivial: = AWS_BYTE_CUR_INIT_FROM_STRING_LITERAL("cookie");
compile-time strlen()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.