New pypi wait strategy to fix release pipeline. #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our release pipeline needs to wait until a newly uploaded version is available in pypi, before installing the new version for testing. We were using `pip search` to determine that the new version was available, but `pip search` has been disabled at a server level (https://status.python.org/incidents/grk0k7sz6zkp). We've had issues with this approach in the past anyway, where it looked like it was globally available, but then didn't install on some specific platform. New strategy is to just retry install attempts until they work (or cap out).
justinboswell
approved these changes
Jan 8, 2021
graebm
added a commit
to aws/aws-iot-device-sdk-python-v2
that referenced
this pull request
Feb 22, 2021
This technique has been used in aws-crt-python (see PR awslabs/aws-crt-python#221) for weeks with great success. Use it here now too.
graebm
added a commit
to aws/aws-iot-device-sdk-python-v2
that referenced
this pull request
Feb 24, 2021
The release pipeline would occasionally fail, due to the flakiness of our wait-for-pypi.py script. This technique has been used in aws-crt-python (see PR awslabs/aws-crt-python#221) for weeks with great success. Use it here now too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKGROUND:
Our release pipeline needs to wait until a newly uploaded version is available in pypi, before installing the new version for testing.
ISSUE:
We were using
pip searchto determine that the new version was available, butpip searchhas been disabled at a server level (https://status.python.org/incidents/grk0k7sz6zkp). We've had issues with this approach in the past anyway, where it looked like it was globally available, but then didn't install on some specific platform.CHANGES:
New strategy is to just retry install attempts until they eventually work (or we cap out).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.