Revert "Remove linker hack (#462)". Always link dependencies statically. #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 25855db.
TingDaoK
approved these changes
Apr 21, 2023
DmitriyMusatkin
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
"Remove linker hack (#462)" caused internal Amazon devs to start having issues building Lambda applications.
Investigation:
In Amazon's internal build system, dependencies are built as both static and shared libs. "Remove linker hack (#462)" resulted in a switch from using static libs, to using the shared libs.
Lambda applications need all their runtime dependencies explicitly packaged up. The switch to use shared libs meant devs needed to add a lot more runtime dependencies.
Description of changes:
Put back code that forces dependencies to be linked statically, to keep things simple and minimize runtime dependencies.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.