fix: Use full UUIDs for random identifiers in integration tests #2043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Oct 31, 2025
| let deleteObjectInput = DeleteObjectInput(bucket: bucketName, key: objectKey) | ||
| _ = try await client.deleteObject(input: deleteObjectInput) | ||
| let deleteObjectInput = DeleteObjectInput(bucket: bucketName, key: objectKey) | ||
| _ = try await client.deleteObject(input: deleteObjectInput) |
There was a problem hiding this comment.
Fixed formatting above
jbelkins
commented
Oct 31, 2025
| // Delete each directory bucket | ||
| for bucket in buckets { | ||
| try await deleteBucket(bucket: bucket) | ||
| } |
There was a problem hiding this comment.
Moved this test cleanup content from the test body to the tearDown() override above, to ensure it gets run after the test.
sichanyoo
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Recently it was noted that there were occasional name collisions between S3 buckets when the buckets were named using the first 8 digits of a UUID for randomness. Switching to full UUIDs appears to have eliminated the problem.
This PR takes every other place that something less than a full UUID was used in a random name, and converts it to a full UUID.
tearDownmethod.New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.